cloud-fan commented on code in PR #36295:
URL: https://github.com/apache/spark/pull/36295#discussion_r882304055
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala:
##########
@@ -141,15 +141,20 @@ case class RowDataSourceScanExec(
handledFilters
}
- val topNOrLimitInfo =
+ val limitOrOffsetInfo =
if (pushedDownOperators.limit.isDefined &&
pushedDownOperators.sortValues.nonEmpty) {
- val pushedTopN =
+ val topNStr =
s"ORDER BY
${seqToString(pushedDownOperators.sortValues.map(_.describe()))}" +
s" LIMIT ${pushedDownOperators.limit.get}"
- Some("PushedTopN" -> pushedTopN)
- } else {
- pushedDownOperators.limit.map(value => "PushedLimit" -> s"LIMIT $value")
- }
+ if (pushedDownOperators.offset.isDefined) {
+ Map("PushedPaging" -> s"$topNStr OFFSET
${pushedDownOperators.offset.get}")
Review Comment:
do we need to combine them into one metrics? I think we can have
`PushedTopN` and `PushedOffset` together in the metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
