peter-toth opened a new pull request, #36687:
URL: https://github.com/apache/spark/pull/36687

   ### What changes were proposed in this pull request?
   
   This is a follow-up to fix `LinkageError` handling in `FileSuite` to avoid 
test suite abort when Snappy native library is not available in low Hadoop 
versions:
   ```
   23:16:22 FileSuite:
   23:16:22 org.apache.spark.FileSuite *** ABORTED ***
   23:16:22   java.lang.RuntimeException: Unable to load a Suite class that was 
discovered in the runpath: org.apache.spark.FileSuite
   23:16:22   at 
org.scalatest.tools.DiscoverySuite$.getSuiteInstance(DiscoverySuite.scala:81)
   23:16:22   at 
org.scalatest.tools.DiscoverySuite.$anonfun$nestedSuites$1(DiscoverySuite.scala:38)
   23:16:22   at 
scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238)
   23:16:22   at scala.collection.Iterator.foreach(Iterator.scala:941)
   23:16:22   at scala.collection.Iterator.foreach$(Iterator.scala:941)
   23:16:22   at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
   23:16:22   at scala.collection.IterableLike.foreach(IterableLike.scala:74)
   23:16:22   at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
   23:16:22   at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
   23:16:22   at scala.collection.TraversableLike.map(TraversableLike.scala:238)
   23:16:22   ...
   23:16:22   Cause: java.lang.UnsatisfiedLinkError: 
org.apache.hadoop.util.NativeCodeLoader.buildSupportsSnappy()Z
   23:16:22   at 
org.apache.hadoop.util.NativeCodeLoader.buildSupportsSnappy(Native Method)
   23:16:22   at 
org.apache.hadoop.io.compress.SnappyCodec.checkNativeCodeLoaded(SnappyCodec.java:63)
   23:16:22   at 
org.apache.hadoop.io.compress.SnappyCodec.getCompressorType(SnappyCodec.java:136)
   23:16:22   at org.apache.spark.FileSuite.$anonfun$new$12(FileSuite.scala:145)
   23:16:22   at scala.util.Try$.apply(Try.scala:213)
   23:16:22   at org.apache.spark.FileSuite.<init>(FileSuite.scala:141)
   23:16:22   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
Method)
   23:16:22   at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
   23:16:22   at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   23:16:22   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
   ```
   Scala's `Try` can handle only `NonFatal` throwables.
   
   ### Why are the changes needed?
   To make the tests robust.
   
   ### Does this PR introduce _any_ user-facing change?
   Nope, this is test-only.
   
   ### How was this patch tested?
   Manual test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to