AngersZhuuuu commented on code in PR #36564: URL: https://github.com/apache/spark/pull/36564#discussion_r883514715
########## core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala: ########## @@ -200,6 +247,42 @@ private[spark] class OutputCommitCoordinator(conf: SparkConf, isDriver: Boolean) } } + private[scheduler] def handleCommitOutputSuccess( + stage: Int, + stageAttempt: Int, + partition: Int, + attemptNumber: Int): Unit = synchronized { + stageStates.get(stage) match { + case Some(state) if attemptFailed(state, stageAttempt, partition, attemptNumber) => + throw new SparkException(s"Authorized committer (attemptNumber=$attemptNumber, " + + s"stage=$stage, partition=$partition) failed; but task commit success, " + + s"should fail the job") Review Comment: Seems throw exception here won't stop the job, any suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org