dongjoon-hyun commented on code in PR #36697:
URL: https://github.com/apache/spark/pull/36697#discussion_r883780623
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanPartitioning.scala:
##########
@@ -40,7 +40,7 @@ object V2ScanPartitioning extends Rule[LogicalPlan] with
SQLConfHelper {
val catalystPartitioning = scan.outputPartitioning() match {
case kgp: KeyGroupedPartitioning => sequenceToOption(kgp.keys().map(
- V2ExpressionUtils.toCatalyst(_, relation, funCatalogOpt)))
+ V2ExpressionUtils.toCatalyst(_, relation, false, funCatalogOpt)))
Review Comment:
If you don't mind, shall we use the following style, @pan3793 ?
```scala
- V2ExpressionUtils.toCatalyst(_, relation, false, funCatalogOpt)))
+ V2ExpressionUtils.toCatalyst(_, relation, strict = false, funCatalogOpt)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
