pan3793 commented on code in PR #36697:
URL: https://github.com/apache/spark/pull/36697#discussion_r884056303
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanPartitioning.scala:
##########
@@ -32,15 +32,15 @@ import
org.apache.spark.util.collection.Utils.sequenceToOption
*/
object V2ScanPartitioning extends Rule[LogicalPlan] with SQLConfHelper {
override def apply(plan: LogicalPlan): LogicalPlan = plan transformDown {
- case d @ DataSourceV2ScanRelation(relation, scan:
SupportsReportPartitioning, _, _) =>
+ case d @ DataSourceV2ScanRelation(relation, scan:
SupportsReportPartitioning, _, None) =>
Review Comment:
After second thought, I think it should only match `None` here, otherwise
`catalystPartitioning` will be calculated every round, if the generated
`catalystPartitioning` contains `Alias`, will cause
`!plan.fastEquals(reOptimized)` and fail `checkBatchIdempotence`.
"SPARK-30289 Create: partitioned by nested column" happen to cover this case
after we changed the `InMemoryTable#outputPartitioning`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
