LuciferYang commented on code in PR #36696:
URL: https://github.com/apache/spark/pull/36696#discussion_r884550646
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala:
##########
@@ -440,94 +440,126 @@ class ParquetFilters(
}
private val makeInPredicate:
- PartialFunction[ParquetSchemaType,
- (Array[String], Array[Any], ParquetStatistics[_]) => FilterPredicate] = {
+ PartialFunction[ParquetSchemaType, (Array[String], Any) =>
FilterPredicate] = {
+ case ParquetBooleanType =>
+ (n: Array[String], v: Any) =>
+ val values = Option(v).map(_.asInstanceOf[Array[Object]]).orNull
Review Comment:
If `orNull` is hit, `for (value <- values) { ... }` will throw NPE
ornull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]