ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884679581
########## sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q65.sf100/explain.txt: ########## @@ -151,106 +152,110 @@ Functions [1]: [avg(revenue#21)] Aggregate Attributes [1]: [avg(revenue#21)#27] Results [2]: [ss_store_sk#13, avg(revenue#21)#27 AS ave#28] -(23) BroadcastExchange +(23) Filter [codegen id : 6] Review Comment: The reason is: both `PromotePrecision` and `CheckOverflow` do not inherit `NullIntolerant`, so the optimizer rule `InferFiltersFromConstraints` can not infer is not null from the inside attribute. It affects all decimal binary arithmetic. This pr removes the`PromotePrecision` and `CheckOverflow` so that we have an extra filter now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
