cloud-fan commented on code in PR #36593:
URL: https://github.com/apache/spark/pull/36593#discussion_r884880249
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -241,6 +246,11 @@ protected String visitSQLFunction(String funcName,
String[] inputs) {
return funcName + "(" +
Arrays.stream(inputs).collect(Collectors.joining(", ")) + ")";
}
+ protected String visitUserDefinedFunction(
+ String funcName, String canonicalName, String[] inputs) {
+ return funcName + "(" +
Arrays.stream(inputs).collect(Collectors.joining(", ")) + ")";
Review Comment:
I think it's safer to fail by default here. We must ask the data sources to
carefully check the `canonicalName` to make sure they support the UDF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
