dongjoon-hyun commented on code in PR #36723:
URL: https://github.com/apache/spark/pull/36723#discussion_r884993022
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -147,10 +147,10 @@ class DataSourceV2SQLSuite
Array("", "", ""),
Array("# Detailed Table Information", "", ""),
Array("Name", "testcat.table_name", ""),
- Array("Comment", "this is a test table", ""),
- Array("Location", "file:/tmp/testcat/table_name", ""),
- Array("Provider", "foo", ""),
Array(TableCatalog.PROP_OWNER.capitalize, defaultUser, ""),
+ Array("Provider", "foo", ""),
+ Array("Location", "file:/tmp/testcat/table_name", ""),
+ Array("Comment", "this is a test table", ""),
Review Comment:
@AngersZhuuuu . Yes, unfortunately, it matters. Personally, I'm -1 if there
is no way to avoid the side-effects.
> Hmmm, dose the order matter? We can add an sort like normal properties to
make it stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
