ueshin commented on code in PR #36640:
URL: https://github.com/apache/spark/pull/36640#discussion_r885963200


##########
python/pyspark/sql/session.py:
##########
@@ -611,8 +611,8 @@ def _inferSchema(
         :class:`pyspark.sql.types.StructType`
         """
         first = rdd.first()
-        if not first:
-            raise ValueError("The first row in RDD is empty, " "can not infer 
schema")
+        if first is None:

Review Comment:
   The `first` can be `None`.
   
   ```py
   >>> print(sc.parallelize([None, 2, 3, 4]).first())
   None
   ```
   
   We should also check if `first is None` because `None` is not `Sized`.
   
   ```py
   >>> isinstance(None, Sized)
   False
   ```
   
   Also we need a test to check the first row is `None` and it fails.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to