dtenedor commented on code in PR #36675:
URL: https://github.com/apache/spark/pull/36675#discussion_r886266583


##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java:
##########
@@ -270,13 +271,40 @@ private void initBatch(
         vectors[i + partitionIdx].setIsConstant();
       }
     }
+
+    // For Parquet tables whose columns have associated DEFAULT values, this 
reader must return
+    // those values instead of NULL when the corresponding columns are not 
present in storage (i.e.
+    // belong to the 'missingColumns' field in this class).
+    ColumnVector[] finalColumns = new 
ColumnVector[sparkSchema.fields().length];

Review Comment:
   Yes, apologies for confusion, this PR is based off of 
https://github.com/apache/spark/pull/36672 which changes the Parquet reader. 
This PR only adds changes for the Orc reader on top of that. Please feel free 
to wait to review this PR again until the base PR is merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to