dongjoon-hyun commented on code in PR #35504:
URL: https://github.com/apache/spark/pull/35504#discussion_r887374892
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala:
##########
@@ -53,18 +53,23 @@ private[spark] class BasicDriverFeatureStep(conf:
KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
+ private val memoryOverheadFactor = if
(conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
+ conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
+ } else {
+ conf.get(MEMORY_OVERHEAD_FACTOR)
+ }
Review Comment:
This is (2) which is a breaking change ignoring the previous user
configurations, `MEMORY_OVERHEAD_FACTOR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
