dongjoon-hyun commented on code in PR #36750:
URL: https://github.com/apache/spark/pull/36750#discussion_r888508050
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -355,14 +355,17 @@ private[hive] class HiveClientImpl(
}
override def alterDatabase(database: CatalogDatabase): Unit = withHiveState {
- if (!getDatabase(database.name).locationUri.equals(database.locationUri)) {
- // SPARK-29260: Enable supported versions once it support altering
database location.
- if (!(version.equals(hive.v3_0) || version.equals(hive.v3_1))) {
- throw
QueryCompilationErrors.alterDatabaseLocationUnsupportedError(version.fullVersion)
- }
- }
+ val loc = getDatabase(database.name).locationUri
+ val changeLoc = !database.locationUri.equals(loc)
+
val hiveDb = toHiveDatabase(database)
shim.alterDatabase(client, database.name, hiveDb)
+
+ if (changeLoc && getDatabase(database.name).locationUri.equals(loc)) {
+ // Some Hive versions don't support changing database location, so we
check here to see if
+ // the location is actually changed, and throw an error if not.
+ throw QueryCompilationErrors.alterDatabaseLocationUnsupportedError()
+ }
Review Comment:
If some HMS forks raise exceptions, it will be enough because it will
propagate to Spark users.
So, this is only for silent HMS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
