Ngone51 commented on code in PR #36716: URL: https://github.com/apache/spark/pull/36716#discussion_r891166646
########## core/src/main/scala/org/apache/spark/deploy/client/StandaloneAppClient.scala: ########## @@ -299,9 +300,10 @@ private[spark] class StandaloneAppClient( * * @return whether the request is acknowledged. */ - def requestTotalExecutors(requestedTotal: Int): Future[Boolean] = { Review Comment: How about leaving this method as it is and delagtes to `requestTotalExecutors(Map(default resource profile -> requestedTotal))` instead? So that some tests remains unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org