amaliujia commented on code in PR #36586: URL: https://github.com/apache/spark/pull/36586#discussion_r891563533
########## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ########## @@ -117,14 +128,44 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog { case NonFatal(_) => None } val isTemp = sessionCatalog.isTempView(tableIdent) + val qualifier = + Array(metadata.map(_.identifier.database).getOrElse(tableIdent.database).orNull) new Table( name = tableIdent.table, Review Comment: done ########## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ########## @@ -117,14 +128,44 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog { case NonFatal(_) => None } val isTemp = sessionCatalog.isTempView(tableIdent) + val qualifier = Review Comment: hm updated. ########## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ########## @@ -97,8 +98,18 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog { */ @throws[AnalysisException]("database does not exist") override def listTables(dbName: String): Dataset[Table] = { - val tables = sessionCatalog.listTables(dbName).map(makeTable) - CatalogImpl.makeDataset(tables, sparkSession) + if (sessionCatalog.databaseExists(dbName)) { Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org