HeartSaVioR commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r891846346
########## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ########## @@ -666,9 +667,10 @@ abstract class KafkaMicroBatchSourceSuiteBase extends KafkaSourceSuiteBase { testUtils.sendMessages(topic2, Array("6")) }, StartStream(), - ExpectFailure[IllegalStateException](e => { + ExpectFailure[SparkException](e => { + assert(e.asInstanceOf[SparkThrowable].getErrorClass === "INTERNAL_ERROR") // The offset of `topic2` should be changed from 2 to 1 - assert(e.getMessage.contains("was changed from 2 to 1")) + assert(e.getCause.getMessage.contains("was changed from 2 to 1")) Review Comment: What makes the time as "illegal" or "inappropriate" is the matter. It does not only bind to the bug of the application. The definition is not strict enough - if we call readTable whereas concurrent operation on non-atomic drop-and-recreate table is happening, the time is "conditionally" "inappropriate". For sure, we can be strict on the project's policy to follow the convention you mentioned (probably define new more-specific exception(s) if needed). For Kafka data source, we'll need some time to sort out on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org