Github user GeorgeDittmar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r30384574
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,23 @@ class SparseVector(
new SparseVector(size, ii, vv)
}
}
+
+ override def argmax: Int = {
+ if (size == 0) {
+ -1
+ } else {
+ var maxIdx = indices(0)
+ var maxValue = values(0)
+
+ foreachActive { (i, v) =>
--- End diff --
Wait are you getting at say I have a sparse vector with zero in it and an
assigned index? Like indices = (1,2,3) values = (-1,0,-.5)? If thats the case
then yes I now see what you are saying but doesnt that same behavior then
happen in dense vectors as well right now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
