zhouyejoe commented on code in PR #35906:
URL: https://github.com/apache/spark/pull/35906#discussion_r892940331
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -576,6 +661,7 @@ public MergeStatuses
finalizeShuffleMerge(FinalizeShuffleMerge msg) {
} finally {
partition.closeAllFilesAndDeleteIfNeeded(false);
}
+
cleanUpAppShufflePartitionInfoInDB(partition.appAttemptShuffleMergeId);
Review Comment:
Just found that we do have a UT which tests that a [finalized
shuffle](https://github.com/apache/spark/pull/35906/files#diff-6dac15558c856c231c284e221b8ae0cdd2ad79c98586eb7e49c3ddcefa53a241R263),
after a restart, getOrCreateAppShufflePartitionInfo will trigger
[BlockPushNonFatalFailure](https://github.com/apache/spark/pull/35906/files#diff-6dac15558c856c231c284e221b8ae0cdd2ad79c98586eb7e49c3ddcefa53a241R289)
with an exception message containing "is finalized". This UT should have
tested that the DB contains the partitionInfo after a successful finalization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
