dongjoon-hyun commented on code in PR #34929: URL: https://github.com/apache/spark/pull/34929#discussion_r893175026
########## sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala: ########## @@ -64,17 +62,6 @@ class QueryExecution( // TODO: Move the planner an optimizer into here from SessionState. protected def planner = sparkSession.sessionState.planner - // The CTE map for the planner shared by the main query and all subqueries. - private val cteMap = mutable.HashMap.empty[Long, CTERelationDef] Review Comment: This move (from `QueryExecutor` to the other location) could be the root cause of the UT failure in GitHub Action. As I posted on https://github.com/apache/spark/pull/36815 , this PR seems to generate the golden answer files with the following correctly. ``` SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStabilitySuite" ``` However, unfortunately, we are experiencing GitHub Action failures. In addition, the result is also different from the one when we run individual query. ``` SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStabilitySuite -- -z (tpcds-v1.4/q4)" ``` Given that, this PR seems to introduce indeterministic logic in terms of expression IDs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
