AngersZhuuuu commented on code in PR #36564:
URL: https://github.com/apache/spark/pull/36564#discussion_r894985147
##########
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala:
##########
@@ -289,6 +289,7 @@ private case class OutputCommitFunctions(tempDirPath:
String) {
// Mock output committer that simulates a failed commit (after commit is
authorized)
private def failingOutputCommitter = new FakeOutputCommitter {
override def commitTask(taskAttemptContext: TaskAttemptContext): Unit = {
+ super.commitTask(taskAttemptContext)
Review Comment:
Revert this change, not need this change.
##########
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorIntegrationSuite.scala:
##########
@@ -46,21 +45,21 @@ class OutputCommitCoordinatorIntegrationSuite
}
test("exception thrown in OutputCommitter.commitTask()") {
- // Regression test for SPARK-10381
- failAfter(Span(60, Seconds)) {
+ val e = intercept[SparkException] {
withTempDir { tempDir =>
sc.parallelize(1 to 4,
2).map(_.toString).saveAsTextFile(tempDir.getAbsolutePath + "/out")
}
- }
+ }.getCause.getMessage
+ assert(e.endsWith("failed; but task commit success, data duplication may
happen."))
}
}
private class ThrowExceptionOnFirstAttemptOutputCommitter extends
FileOutputCommitter {
override def commitTask(context: TaskAttemptContext): Unit = {
val ctx = TaskContext.get()
+ super.commitTask(context)
Review Comment:
revert now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
