dongjoon-hyun commented on code in PR #36832:
URL: https://github.com/apache/spark/pull/36832#discussion_r895262820
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -747,6 +747,15 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
listing.synchronized {
listing.delete(classOf[LogInfo], rootPath.toString)
}
+ case _: FileNotFoundException
+ if reader.rootPath.getName.endsWith(EventLogFileWriter.IN_PROGRESS)
=>
+ val finalFileName =
reader.rootPath.getName.stripSuffix(EventLogFileWriter.IN_PROGRESS)
+ if (fs.exists(new Path(reader.rootPath.getParent, finalFileName))) {
+ // Do nothing, the application completed during processing, the
final event log file
+ // will be processed by next around.
+ } else {
+ logError(s"File does not exist: ${reader.rootPath}")
Review Comment:
In addition, this is not a critical error in SHS. `logWarning` could be
enough in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
