dongjoon-hyun commented on code in PR #36841: URL: https://github.com/apache/spark/pull/36841#discussion_r897119553
########## sql/core/src/test/resources/sql-tests/inputs/non-excludable-rule.sql: ########## @@ -4,3 +4,12 @@ SELECT (SELECT min(id) FROM range(10)), (SELECT sum(id) FROM range(10)), (SELECT count(distinct id) FROM range(10)); + +-- SPARK-39444 +SET spark.sql.optimizer.excludedRules=org.apache.spark.sql.catalyst.optimizer.Optimizer$OptimizeSubqueries; Review Comment: Although it was working, I didn't realize that we allow to exclude rules whose prefix is `Optimizer$...`. Is it legitimate? I'm just curious if we need to ban all exclusions for ``Optimizer$...` rules. ########## sql/core/src/test/resources/sql-tests/inputs/non-excludable-rule.sql: ########## @@ -4,3 +4,12 @@ SELECT (SELECT min(id) FROM range(10)), (SELECT sum(id) FROM range(10)), (SELECT count(distinct id) FROM range(10)); + +-- SPARK-39444 +SET spark.sql.optimizer.excludedRules=org.apache.spark.sql.catalyst.optimizer.Optimizer$OptimizeSubqueries; Review Comment: Although it was working, I didn't realize that we allow to exclude rules whose prefix is `Optimizer$...`. Is it legitimate? I'm just curious if we need to ban all exclusions for `Optimizer$...` rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
