HyukjinKwon commented on code in PR #36413:
URL: https://github.com/apache/spark/pull/36413#discussion_r897427925


##########
.github/workflows/build_and_test.yml:
##########
@@ -280,6 +280,7 @@ jobs:
       with:
         name: test-results-${{ matrix.modules }}-${{ matrix.comment }}-${{ 
matrix.java }}-${{ matrix.hadoop }}-${{ matrix.hive }}
         path: "**/target/test-reports/*.xml"
+        if-no-files-found: error

Review Comment:
   We can try and go ahead, I'm not against this. My only concern is that we'll 
now consider the build as failed in the case when the build is successful but 
it failed to generate XML test reports for an unknown reason - this happens 
often as far as I remember. Though, I agree that this PR can make such unknown 
cases onto the surface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to