Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6034#discussion_r30387131
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDDOperationScope.scala
---
@@ -43,10 +43,9 @@ import org.apache.spark.SparkContext
@JsonPropertyOrder(Array("id", "name", "parent"))
private[spark] class RDDOperationScope(
val name: String,
+ val id: String = RDDOperationScope.nextScopeId().toString,
--- End diff --
Super Nit: typically default params are ordered based on what is more
likely to get explicitly specified. I think `parent` is more likely be
specified by callers than the `id`, so should be ordered accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
