cloud-fan commented on code in PR #36873:
URL: https://github.com/apache/spark/pull/36873#discussion_r897659097
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala:
##########
@@ -358,8 +358,16 @@ object UnwrapCastInBinaryComparison extends
Rule[LogicalPlan] {
toType.sameType(literalType) &&
!fromExp.foldable &&
toType.isInstanceOf[NumericType] &&
- ((fromExp.dataType.isInstanceOf[NumericType] &&
Cast.canUpCast(fromExp.dataType, toType)) ||
- fromExp.dataType.isInstanceOf[BooleanType])
+ canUnwrapCast(fromExp.dataType, toType)
+ }
+
+ private def canUnwrapCast(from: DataType, to: DataType): Boolean = (from,
to) match {
+ case (BooleanType, _) => true
+ case (IntegerType, FloatType) => false
Review Comment:
can we add some code comments to explain the reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
