Jonathancui123 commented on code in PR #36871:
URL: https://github.com/apache/spark/pull/36871#discussion_r898222912
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala:
##########
@@ -117,8 +124,8 @@ class CSVInferSchema(val options: CSVOptions) extends
Serializable {
case LongType => tryParseLong(field)
case _: DecimalType => tryParseDecimal(field)
case DoubleType => tryParseDouble(field)
- case TimestampNTZType => tryParseTimestampNTZ(field)
- case TimestampType => tryParseTimestamp(field)
+ // Temporary NOTE: DateTimeType is private to [sql] package
+ case DateType | TimestampNTZType | TimestampType => tryParseDate(field)
Review Comment:
Rename to `tryParseDate`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala:
##########
@@ -117,8 +124,8 @@ class CSVInferSchema(val options: CSVOptions) extends
Serializable {
case LongType => tryParseLong(field)
case _: DecimalType => tryParseDecimal(field)
case DoubleType => tryParseDouble(field)
- case TimestampNTZType => tryParseTimestampNTZ(field)
- case TimestampType => tryParseTimestamp(field)
+ // Temporary NOTE: DateTimeType is private to [sql] package
+ case DateType | TimestampNTZType | TimestampType => tryParseDate(field)
Review Comment:
Rename to `tryParseDateTime`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
