JoshRosen commented on code in PR #36885:
URL: https://github.com/apache/spark/pull/36885#discussion_r898647504
##########
core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala:
##########
@@ -916,13 +958,13 @@ private[spark] object JsonProtocolSuite extends
Assertions {
}
private def assertJsonStringEquals(expected: String, actual: String,
metadata: String): Unit = {
- val expectedJson = parse(expected)
- val actualJson = parse(actual)
+ val expectedJson = mapper.readTree(expected)
+ val actualJson = mapper.readTree(actual)
if (expectedJson != actualJson) {
// scalastyle:off
// This prints something useful if the JSON strings don't match
- println(s"=== EXPECTED ===\n${pretty(expectedJson)}\n")
Review Comment:
I should probably find a way to preserve the pretty formatting in the debug
output. Maybe I can configure the mapper used here in the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
