huaxingao commented on code in PR #36877:
URL: https://github.com/apache/spark/pull/36877#discussion_r898741454
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -542,6 +544,60 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
}
checkPushedInfo(df8, expectedPlanFragment8)
checkAnswer(df8, Seq(Row(2, "david", 10000, 1300, true)))
+
+ val df9 = spark.table("h2.test.employee")
+ .filter(logarithm(2, $"dept") > 2)
+ .filter(log10($"dept") > 0.5)
+ .filter(round($"dept") > 1)
+ .filter(degrees($"dept") > 100)
+ .filter(radians($"dept") > 0.1)
+ .filter(signum($"dept") === 1)
+ checkFiltersRemoved(df9, ansiMode)
Review Comment:
I think you have `Cast`, which is affected by `ansiMode`. I feel it is
cleaner to only test the newly added non-ansi functions, without mixing with
the ansi functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
