cloud-fan commented on code in PR #36564:
URL: https://github.com/apache/spark/pull/36564#discussion_r899208451
##########
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala:
##########
@@ -235,7 +226,6 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite
with BeforeAndAfter {
assert(!outputCommitCoordinator.canCommit(stage, 3, partition,
taskAttempt))
outputCommitCoordinator.taskCompleted(stage, 1, partition, taskAttempt,
ExecutorLostFailure("0", exitCausedByApp = true, None))
- assert(outputCommitCoordinator.canCommit(stage, 4, partition, taskAttempt))
Review Comment:
It has not been updated yet
```
// Commit the 1st attempt, fail the 2nd attempt, make sure 3rd attempt
cannot commit,
// then fail the 1st attempt and make sure the 4th one can commit again.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
