dongjoon-hyun commented on code in PR #36894:
URL: https://github.com/apache/spark/pull/36894#discussion_r899638650
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientVersions.scala:
##########
@@ -22,7 +22,10 @@ import scala.collection.immutable.IndexedSeq
import org.apache.commons.lang3.{JavaVersion, SystemUtils}
private[client] trait HiveClientVersions {
- protected val versions = if
(SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ private val testVersions = sys.env.get("SPARK_TEST_HIVE_CLIENT_VERSIONS")
+ protected val versions = if (testVersions.nonEmpty) {
+ testVersions.get.split(",").map(_.strip).filter(_.nonEmpty).toIndexedSeq
Review Comment:
Oops. I forgot that `String.strip` was added in Java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
