xinrong-databricks commented on code in PR #36893:
URL: https://github.com/apache/spark/pull/36893#discussion_r899675695
##########
python/pyspark/sql/session.py:
##########
@@ -1024,7 +1024,18 @@ def prepare(obj: Any) -> Any:
if isinstance(data, RDD):
rdd, struct = self._createFromRDD(data.map(prepare), schema,
samplingRatio)
else:
- rdd, struct = self._createFromLocal(map(prepare, data), schema)
+ if isinstance(data, list):
+ # Wrap each element with a tuple if there is any scalar in the
list
+ has_scalar = False
+ for x in data:
+ if isinstance(x, str) or not hasattr(x, "__len__"): #
Scalar
+ has_scalar = True
+ break
Review Comment:
Looks much cleaner! I guess Python `any` should return immediately when it
detects the **first** `True`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
