LuciferYang commented on code in PR #36934:
URL: https://github.com/apache/spark/pull/36934#discussion_r902224853


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1272,8 +1272,11 @@ object InferFiltersFromConstraints extends 
Rule[LogicalPlan]
   private def inferFilters(plan: LogicalPlan): LogicalPlan = 
plan.transformWithPruning(
     _.containsAnyPattern(FILTER, JOIN)) {
     case filter @ Filter(condition, child) =>
-      val newFilters = filter.constraints --

Review Comment:
   > [SPARK-39520](https://issues.apache.org/jira/browse/SPARK-39520) was not 
merged to 3.3, do we have this issue in 3.3?
   
   @cloud-fan 3.3 no this issue due to SPARK-38836 not in branch-3.3, the `--` 
method hasn't been deleted, and I manually check the relevant suites(inlcude 
TPCDSV1_4_PlanStabilitySuite, AdaptiveQueryExecSuite, ExpressionSetSuite, 
JDBCV2Suite, GeneratorFunctionSuite), all passed.
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to