cloud-fan commented on code in PR #36909:
URL: https://github.com/apache/spark/pull/36909#discussion_r902664764
##########
sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala:
##########
@@ -1324,7 +1325,17 @@ class JoinSuite extends QueryTest with
SharedSparkSession with AdaptiveSparkPlan
val plan = sql(getAggQuery(selectExpr,
joinType)).queryExecution.executedPlan
assert(collect(plan) { case _: BroadcastNestedLoopJoinExec => true
}.size === 1)
// No extra shuffle before aggregation
- assert(collect(plan) { case _: ShuffleExchangeExec => true }.size
=== 0)
+ if (joinType.equals("LEFT SEMI") || joinType.equals("LEFT ANTI")) {
+ assert(collect(plan) {
+ case s: ShuffleExchangeExec if s.outputPartitioning !=
SinglePartition => true
+ }.size === 0)
+ // Shuffle Exchange between LocalLimit and GlobalLimit
Review Comment:
does it mean it's safer to only add an extra local limit. not global limit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
