cloud-fan commented on code in PR #36941:
URL: https://github.com/apache/spark/pull/36941#discussion_r902729080
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala:
##########
@@ -531,6 +532,15 @@ class DataFrameWriterV2Suite extends QueryTest with
SharedSparkSession with Befo
assert(table.properties === (Map("provider" -> "foo") ++
defaultOwnership).asJava)
}
+ test("SPARK-39543 writeOption should be passed to storage properties when
fallback to v1") {
+ spark.range(10).writeTo("table_name").option("compression",
"zstd").using("parquet").create()
Review Comment:
can we test with `InMemoryV1Provider`? We may migrate the file source to v2
completely in the future and then this test won't test the v1 fallback anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
