ivoson commented on code in PR #36716:
URL: https://github.com/apache/spark/pull/36716#discussion_r902832247
##########
core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala:
##########
@@ -54,6 +54,7 @@ private[spark] class ResourceProfileManager(sparkConf:
SparkConf,
private val master = sparkConf.getOption("spark.master")
private val isYarn = master.isDefined && master.get.equals("yarn")
private val isK8s = master.isDefined && master.get.startsWith("k8s://")
+ private val isStandalone = master.isDefined &&
master.get.startsWith("spark://")
Review Comment:
Here we only try to support standalone cluster here. The reason for the
local-cluster code change in `ResourceProfile` is that local-cluster and
standalone share the same `StandaloneSchedulerBackend` and Master. After the
changes in this PR, the master will schedule based on resource profile, so we
also need to create default resource profile for local-cluster. Does this make
sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
