Yikun commented on code in PR #36353:
URL: https://github.com/apache/spark/pull/36353#discussion_r904950232
##########
python/pyspark/pandas/tests/test_dataframe.py:
##########
@@ -270,7 +270,12 @@ def test_inplace(self):
psdf["a"] = psdf["a"] + 10
self.assert_eq(psdf, pdf)
- self.assert_eq(psser, pser)
+ # SPARK-38946: Since Spark 3.4, inplace set generate a new dataframe
to follow
+ # pandas 1.4 behaviors
+ if LooseVersion(pd.__version__) >= LooseVersion("1.4"):
+ self.assert_eq(psser, pser)
Review Comment:
we follow latest behavior, so before 1.3 will raise not equal. added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
