amaliujia commented on code in PR #36969:
URL: https://github.com/apache/spark/pull/36969#discussion_r905484781
##########
sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala:
##########
@@ -743,4 +743,35 @@ class CatalogSuite extends SharedSparkSession with
AnalysisTest with BeforeAndAf
val catalogName2 = "catalog_not_exists"
assert(!spark.catalog.databaseExists(Array(catalogName2,
dbName).mkString(".")))
}
+
+ test("three layer namespace compatibility - current database") {
Review Comment:
hmm I think you can also update `currentDatabase` API and the test will be
simplified:
`setCurrentNamespace` then check `currentNamespace`
https://github.com/databricks/runtime/blob/ca9cfac39f6ca160091cc3a1d7727ee0f784d044/sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala#L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
