wzx140 commented on PR #36973: URL: https://github.com/apache/spark/pull/36973#issuecomment-1165741695
> Code changes LGTM. I checked the other place the deserializer uses a `ByteBuffer`, in the `(BYTES, _: DecimalType)` case, and it doesn't have the same problem because `decimalConversions.fromBytes()` duplicates the `ByteBuffer` before extracting from it. > > Can you update the PR description to have more details on why this is needed, basically what you described in [your comment](https://github.com/apache/spark/pull/36973/files#r906183583)? It might also be helpful to update the summary to be more descriptive about the impact rather than the mechanics of the change, something like "Fix repeated deserialization of BYTES type in AvroDeserializer" (and then the body can describe the mechanical/technical aspects of the change). @xkrogen Already updated the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
