Yaohua628 commented on code in PR #36851:
URL: https://github.com/apache/spark/pull/36851#discussion_r906392455


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SchemaPruning.scala:
##########
@@ -103,8 +104,14 @@ object SchemaPruning extends Rule[LogicalPlan] {
     }
   }
 
+  private def containsNestedColumn(fsRelation: HadoopFsRelation): Boolean =

Review Comment:
   We combined them in the same logic at `prunePhysicalColumns(...)`. And the 
flag `NESTED_SCHEMA_PRUNING_ENABLED` controls only data schema 
([here](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SchemaPruning.scala#L73)),
 but not `_metadata`. 
   
   Basically, we try to prune `_metadata` regardless of the flag and the file 
format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to