cloud-fan commented on code in PR #36966:
URL: https://github.com/apache/spark/pull/36966#discussion_r907040117
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -710,18 +711,20 @@ class AdaptiveQueryExecSuite
test("SPARK-37753: Inhibit broadcast in left outer join when there are many
empty" +
" partitions on outer/left side") {
- withSQLConf(
- SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
- SQLConf.NON_EMPTY_PARTITION_RATIO_FOR_BROADCAST_JOIN.key -> "0.5") {
- // `testData` is small enough to be broadcast but has empty partition
ratio over the config.
- withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "200") {
- val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(
- "SELECT * FROM (select * from testData where value = '1') td" +
- " left outer join testData2 ON key = a")
- val smj = findTopLevelSortMergeJoin(plan)
- assert(smj.size == 1)
- val bhj = findTopLevelBroadcastHashJoin(adaptivePlan)
- assert(bhj.isEmpty)
+ eventually(timeout(40.seconds), interval(500.milliseconds)) {
Review Comment:
the interval is 500 ms, do you know how long this test takes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
