HeartSaVioR commented on code in PR #36963: URL: https://github.com/apache/spark/pull/36963#discussion_r907063933
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/WriteToMicroBatchDataSourceV1.scala: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.streaming.sources + +import org.apache.spark.sql.catalyst.catalog.CatalogTable +import org.apache.spark.sql.catalyst.expressions.Attribute +import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, UnaryNode} +import org.apache.spark.sql.execution.streaming.Sink +import org.apache.spark.sql.streaming.OutputMode + +/** + * Marker node to represent a DSv1 sink on streaming query. + * + * Despite this is expected to be the top node, this node should behave like "pass-through" + * since the DSv1 codepath on microbatch execution handles sink operation separately. + * + * This node is eliminated in streaming specific optimization phase, which means there is no + * matching physical node. + */ +case class WriteToMicroBatchDataSourceV1( + catalogTable: Option[CatalogTable], + sink: Sink, + query: LogicalPlan, + queryId: String, + writeOptions: Map[String, String], + outputMode: OutputMode, + batchId: Option[Long] = None) Review Comment: Previous self-comment: > It'd be nice if we can deal with [SPARK-27484](https://issues.apache.org/jira/browse/SPARK-27484), but let's defer it as of now as it may bring additional works/concerns. These parameters could probably help us to go with SPARK-27484. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
