Eugene-Mark commented on code in PR #36993:
URL: https://github.com/apache/spark/pull/36993#discussion_r907478695
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -924,6 +924,13 @@ class JDBCSuite extends QueryTest
assert(derbyDialect.getJDBCType(BooleanType).map(_.databaseTypeDefinition).get
== "BOOLEAN")
}
+ test("SPARK-39604: DerbyDialect catalyst type mapping") {
+ val derbyDialect = JdbcDialects.get("jdbc:derby:db")
+ val metadata = new MetadataBuilder().putString("name", "test_column")
+ assert(derbyDialect.getCatalystType(java.sql.Types.REAL, "real",
+ 0, metadata) == Some(FloatType))
Review Comment:
I'm Okay to put them all together or separate the others just like how
MysqlDialacts did. But I'm neutral to which one is better, may I kindly know
your preference about it? @wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
