ulysses-you commented on PR #36936:
URL: https://github.com/apache/spark/pull/36936#issuecomment-1168150746

   The change list to help reviewer:
   ```scala
   
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
                  |   3 ++-
   
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
               |  16 +++++++++++-----
   
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
                    |  12 ++++++++++--
   sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala  
                        |  40 +++++++++++++++++++++++++++++++---------
   
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
                 |  47 ++++++++++++++++++++++++++++++-----------------
   sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala      
                        |   9 +++++++++
   
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
          |  41 +++++++++++++++++++++++------------------
   
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
         |   9 ++++++---
   sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala           
                        |   3 ++-
   
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala 
                     |   3 ++-
   
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzePartitionCommand.scala
         |   5 +++--
   
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
          |   9 ++++++---
   sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala     
                        |  21 ++++++++++++---------
   
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala  
                     |   9 ++++++---
   sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala  
                        |  36 +++++++++++++++++++++++-------------
   
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala
             |   4 +++-
   
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala  
                     |  19 +++++++++++--------
   
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
    |   1 +
   
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
                  |   8 ++++----
   sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala      
                        |  57 
++++++++++++++++++++++++++++++++++----------------------
   
   sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala    
                        |  10 +++++++---
   
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala
                     |   4 +++-
   
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala   
                     |  24 +++++++++++++++---------
   
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DescribeNamespaceSuite.scala
       |  12 +++++++-----
   
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DescribeTableSuite.scala
           |   2 ++
   
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/DescribeNamespaceSuite.scala
       |   1 +
   
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
                  |   3 ++-
   sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala  
                        |  19 ++++++++++---------
   sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala 
                        |   9 ++++++---
   sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala       
                        |   4 +++-
   
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
                |   4 +++-
   
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
                    |  24 ++++++++++++++----------
   sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala      
                        |   7 ++++---
   sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala             
                        |   9 +++++----
   
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala  
                     |  22 ++++++++++++++--------
   
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
                   |   3 ++-
   
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveTableScanSuite.scala
                 |  13 +++++++------
   
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala  
                     |   3 ++-
   
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala 
                     |  11 +++++++----
   
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/DescribeTableSuite.scala
         |   2 ++
   
   sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out            
                        |  16 +++++++++++++++-
   
sql/core/src/test/resources/sql-tests/results/describe-part-after-analyze.sql.out
                    |   7 +++++++
   
sql/core/src/test/resources/sql-tests/results/describe-table-after-alter-table.sql.out
               |   5 +++++
   sql/core/src/test/resources/sql-tests/results/describe.sql.out               
                        |  23 +++++++++++++++--------
   sql/core/src/test/resources/sql-tests/results/explain-aqe.sql.out            
                        | 104 
+++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------
   sql/core/src/test/resources/sql-tests/results/explain-cbo.sql.out            
                        |   8 ++++----
   sql/core/src/test/resources/sql-tests/results/explain.sql.out                
                        |  96 
+++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------
   sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out     
                        |   2 +-
   sql/core/src/test/resources/sql-tests/results/show-tables.sql.out            
                        |  10 ++++++----
   sql/core/src/test/resources/sql-tests/results/udaf.sql.out                   
                        |   2 +-
   sql/core/src/test/resources/sql-tests/results/udf/udf-udaf.sql.out           
                        |   2 +-
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to