yeachan153 commented on code in PR #36434:
URL: https://github.com/apache/spark/pull/36434#discussion_r908139374
##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/decom.sh:
##########
@@ -18,17 +18,24 @@
#
-set -ex
+set +e
+set -x
echo "Asked to decommission"
# Find the pid to signal
date | tee -a ${LOG}
-WORKER_PID=$(ps -o pid -C java | tail -n 1| awk '{ sub(/^[ \t]+/, ""); print
}')
+WORKER_PID=$(ps x -o pid,cmd -C java |grep Executor \
Review Comment:
Here it is:
<img width="1626" alt="image"
src="https://user-images.githubusercontent.com/30076090/176118840-7681517d-b53b-4c50-a1b9-7ca119f2e05d.png";>
Tailing the last line seems to grab the process running `grep executor`
rather than the actual executor process
> incase someones runing another java process inside the executor container.
Also not completely sure, in our case the previous implementation correctly
selected the pid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/30076090/176118840-7681517d-b53b-4c50-a1b9-7ca119f2e05d.png"](https://user-images.githubusercontent.com/30076090/176118840-7681517d-b53b-4c50-a1b9-7ca119f2e05d.png"){kind=link}