sunchao commented on code in PR #36616:
URL: https://github.com/apache/spark/pull/36616#discussion_r909231193
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DataSourceReadBenchmark.scala:
##########
@@ -607,6 +607,38 @@ object DataSourceReadBenchmark extends SqlBasedBenchmark {
}
}
+ def vectorizedScanPartitionColumnsBenchmark(values: Int, pColumns: Int):
Unit = {
Review Comment:
Thanks. I feel we can just showing the benchmark result in the PR instead of
adding it to `DataSourceReadBenchmark`. In this PR we already added dedicated
benchmarks for the constant vector so here it seems a bit redundant especially
since there is no base case to compare to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
