sadikovi commented on code in PR #37013:
URL: https://github.com/apache/spark/pull/37013#discussion_r909238043
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -599,10 +610,13 @@ object JdbcUtils extends Logging with SQLConfHelper {
stmt.setTimestamp(pos + 1,
toJavaTimestamp(instantToMicros(row.getAs[Instant](pos))))
} else {
(stmt: PreparedStatement, row: Row, pos: Int) =>
- stmt.setTimestamp(
- pos + 1,
-
toJavaTimestamp(localDateTimeToMicros(row.getAs[java.time.LocalDateTime](pos)))
- )
+ val micros =
localDateTimeToMicros(row.getAs[java.time.LocalDateTime](pos))
+ val seconds = Math.floorDiv(micros,
DateTimeConstants.MICROS_PER_SECOND)
+ val nanos = (micros - seconds * DateTimeConstants.MICROS_PER_SECOND)
*
+ DateTimeConstants.NANOS_PER_MICROS
+ val result = new java.sql.Timestamp(seconds *
DateTimeConstants.MILLIS_PER_SECOND)
Review Comment:
Are you saying that `toJavaTimestamp` rebases the original value, i.e. adds
an offset, so `java.sql.Timestamp` ends up with that offset causing the date to
be different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
