cloud-fan commented on code in PR #36968:
URL: https://github.com/apache/spark/pull/36968#discussion_r910528924
##########
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala:
##########
@@ -296,7 +300,36 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
* `Database` can be found.
*/
override def getDatabase(dbName: String): Database = {
- makeDatabase(dbName)
+ // `dbName` could be either a single database name (behavior in Spark 3.3
and prior) or a
+ // qualified namespace with catalog name. To maintain backwards
compatibility, we first assume
+ // it's a single database name and return the database from sessionCatalog
if it exists.
+ // Otherwise we try 3-part name parsing and locate the database. If the
parased identifier
+ // contains both catalog name and database name, we then search the
database in the catalog.
+ if (sessionCatalog.databaseExists(dbName) ||
sessionCatalog.isGlobalTempViewDB(dbName)) {
+ makeDatabase(dbName)
+ } else {
+ val ident =
sparkSession.sessionState.sqlParser.parseMultipartIdentifier(dbName)
+ val plan = UnresolvedNamespace(ident)
+ val resolved = sparkSession.sessionState.executePlan(plan).analyzed
+ resolved match {
+ case ResolvedNamespace(catalog: SupportsNamespaces, namespace) =>
+ val metadata = catalog.loadNamespaceMetadata(namespace.toArray)
+ new Database(
+ name = namespace.mkString("."),
+ catalog = catalog.name,
+ description = metadata.get(SupportsNamespaces.PROP_COMMENT),
+ locationUri = metadata.get(SupportsNamespaces.PROP_LOCATION))
+ // similar to databaseExists: if the catalog doesn't support
namespaces, we assume it's an
+ // implicit namespace, which exists but has no metadata.
+ case ResolvedNamespace(catalog: CatalogPlugin, namespace) =>
+ new Database(
+ name = dbName,
Review Comment:
let's generate database name from `namespace`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
