cloud-fan commented on code in PR #37021:
URL: https://github.com/apache/spark/pull/37021#discussion_r910754728
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala:
##########
@@ -37,16 +41,44 @@ sealed trait IdentifierWithDatabase {
val replacedId = quoteIdentifier(identifier)
val replacedDb = database.map(quoteIdentifier(_))
Review Comment:
this doesn't matter, but I think it's still better to do it to keep
consistent with table and database name, otherwise we need to explain to people
that the catalog name is always `spark_catalog` so we don't need to quote it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
