cloud-fan commented on code in PR #36885:
URL: https://github.com/apache/spark/pull/36885#discussion_r911945077
##########
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala:
##########
@@ -86,18 +84,17 @@ private[spark] class EventLoggingListener(
private def initEventLog(): Unit = {
val metadata = SparkListenerLogStart(SPARK_VERSION)
- val eventJson = JsonProtocol.logStartToJson(metadata)
- val metadataJson = compact(eventJson)
- logWriter.writeEvent(metadataJson, flushLogger = true)
+ val eventJson = JsonProtocol.sparkEventToJsonString(metadata)
+ logWriter.writeEvent(eventJson, flushLogger = true)
Review Comment:
Not related to this PR: does it mean we generate a big JSON string and write
it to files? Is it possible to do it in a streaming fashion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
