MaxGekk commented on code in PR #37036:
URL: https://github.com/apache/spark/pull/37036#discussion_r912083948
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowFunctionsSuiteBase.scala:
##########
@@ -38,9 +38,11 @@ import org.apache.spark.util.Utils
trait ShowFunctionsSuiteBase extends QueryTest with DDLCommandTestUtils {
override val command = "SHOW FUNCTIONS"
+ protected def funCatalog: String = catalog
protected def createFunction(name: String): Unit = {}
protected def dropFunction(name: String): Unit = {}
protected def showFun(ns: String, name: String): String =
s"$ns.$name".toLowerCase(Locale.ROOT)
+ protected def isTempFunctions(): Boolean = false
Review Comment:
I have added a test which checks temp functions in v2 impl. Would you mind
if we improve test coverage in another PR since this PR aims to support v2
mostly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
